as the shade runs after the hpi package all that happens is that the classess get copied into the root of the HPI.
classes are never loaded from here and there is a copy in WEB-INF\lib\gcp-client-xxx.jar that is used, and this has been working for a while.
whilst there may also be a gcp-client or classes in other places that this plugin has dependencies to I saw no gcp-client in google-oath-credentials which would be the only logical place. Additionally if it was not broken before this fix it would remain not broken after this fix.
Testing done
none.
### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
Was introduced in https://github.com/jenkinsci/google-compute-engine-plugin/commit/49dc7bcf4b7f8f89e5bac86085eee1d64aa0c54b but this is a waste of space.
as the shade runs after the hpi package all that happens is that the classess get copied into the root of the HPI. classes are never loaded from here and there is a copy in
WEB-INF\lib\gcp-client-xxx.jarthat is used, and this has been working for a while.whilst there may also be a
gcp-clientor classes in other places that this plugin has dependencies to I saw no gcp-client ingoogle-oath-credentialswhich would be the only logical place. Additionally if it was not broken before this fix it would remain not broken after this fix.Testing done
none.