jenkinsci / google-oauth-plugin

This plugin implements the OAuth Credentials interfaces to surface Google Service Account credentials to Jenkins.
https://plugins.jenkins.io/google-oauth-plugin/
Apache License 2.0
37 stars 56 forks source link

Bump fmt-maven-plugin to 2.9 to improve build stability #180

Closed cathychan closed 1 year ago

cathychan commented 1 year ago

In our CI, the various google-xxx plugins fail to build from time to time, with the following error:

[ERROR] Failed to execute goal com.coveo:fmt-maven-plugin:2.8:format (default) on project google-compute-engine: Execution default of goal com.coveo:fmt-maven-plugin:2.8:format failed. ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 0 -> [Help 1]

I tracked this down to https://github.com/spotify/fmt-maven-plugin/issues/42. The issue was fixed in https://github.com/spotify/fmt-maven-plugin/pull/52 and released in 2.9, which is compatible with Java 8. (I see that bumping to 2.10 (#116, #163) and beyond was unsuccessful). I propose bumping to 2.9 to pick up this helpful fix until the plugin eventually advances to Java 11.

Testing done

Builds locally, i.e. no regression. Only time will tell whether the flakiness is fully addressed as expected.

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue