jenkinsci / google-storage-plugin

This plugin provides the “Google Cloud Storage Uploader” post-build step for publishing build artifacts to Google Cloud Storage.
https://plugins.jenkins.io/google-storage-plugin/
Apache License 2.0
31 stars 57 forks source link

Plugin prompts an error but exit status is ok #221

Open sbenish opened 2 years ago

sbenish commented 2 years ago

Jenkins and plugins versions report

Jenkins: 2.346.2 OS: Linux - 5.10.118

ace-editor:1.1 allure-jenkins-plugin:2.30.2 ansicolor:1.0.2 ant:475.vf34069fef73c antisamy-markup-formatter:2.7 apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61 artifactory:3.17.0 audit-trail:3.11 authentication-tokens:1.4 aws-credentials:191.vcb_f183ce58b_9 aws-global-configuration:100.v4619b_45d2dfc aws-java-sdk:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-cloudformation:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-codebuild:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-ec2:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-ecr:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-ecs:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-elasticbeanstalk:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-iam:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-logs:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-minimal:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-sns:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-sqs:1.12.246-349.v96b_b_f7eb_a_c3c aws-java-sdk-ssm:1.12.246-349.v96b_b_f7eb_a_c3c aws-secrets-manager-credentials-provider:1.2.0 aws-secrets-manager-secret-source:0.0.3 basic-branch-build-strategies:1.3.2 blueocean:1.25.6 blueocean-autofavorite:1.2.5 blueocean-bitbucket-pipeline:1.25.6 blueocean-commons:1.25.6 blueocean-config:1.25.6 blueocean-core-js:1.25.6 blueocean-dashboard:1.25.6 blueocean-display-url:2.4.1 blueocean-events:1.25.6 blueocean-git-pipeline:1.25.6 blueocean-github-pipeline:1.25.6 blueocean-i18n:1.25.6 blueocean-jwt:1.25.6 blueocean-personalization:1.25.6 blueocean-pipeline-api-impl:1.25.6 blueocean-pipeline-editor:1.25.6 blueocean-pipeline-scm-api:1.25.6 blueocean-rest:1.25.6 blueocean-rest-impl:1.25.6 blueocean-web:1.25.6 bootstrap5-api:5.2.0-1 bouncycastle-api:2.26 branch-api:2.1046.v0ca_37783ecc5 build-user-vars-plugin:1.8 build-with-parameters:1.6 caffeine-api:2.9.3-65.v6a_47d0f4d1fe checks-api:1.7.5 cloudbees-bitbucket-branch-source:785.ve724eb_44e286 cloudbees-folder:6.740.ve4f4ffa_dea_54 cobertura:1.17 code-coverage-api:3.0.5 command-launcher:84.v4a_97f2027398 config-file-provider:3.11.1 configuration-as-code:1512.vb_79d418d5fc8 credentials:1139.veb_9579fca33b credentials-binding:523.vd859a_4b_122e6 data-tables-api:1.12.1-2 datadog:4.0.0 display-url-api:2.3.6 docker-commons:1.19 docker-workflow:521.v1a_a_dd2073b_2e durable-task:500.v8927d9fd99d8 dynamic_extended_choice_parameter:1.0.1 ec2:1.68 echarts-api:5.3.3-1 extended-choice-parameter:346.vd87693c5a_86c extended-read-permission:3.2 favorite:2.4.1 font-awesome-api:6.1.2-1 forensics-api:1.15.1 git:4.11.4 git-client:3.11.2 github:1.34.5 github-api:1.303-400.v35c2d8258028 github-autostatus:3.6.2 github-branch-source:1677.v731f745ea_0cf github-checks:1.0.18 google-metadata-plugin:0.3.1 google-oauth-plugin:1.0.6 google-storage-plugin:1.5.6 gradle:1.39.4 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-22.v77d5b_75e6953 htmlpublisher:1.30 ignore-committer-strategy:1.0.4 ivy:2.2 jackson2-api:2.13.3-285.vc03c0256d517 jacoco:3.3.2 jakarta-activation-api:2.0.1-1 jakarta-mail-api:2.0.1-1 javadoc:226.v71211feb_e7e9 javax-activation-api:1.2.0-4 javax-mail-api:1.6.2-5 jaxb:2.3.6-1 jdk-tool:1.0 jenkins-design-language:1.25.6 jjwt-api:0.11.5-77.v646c772fddb_0 jnr-posix-api:3.1.15-1 job-dsl:1.81 jobConfigHistory:1165.v8cc9fd1f4597 jquery:1.12.4-1 jquery3-api:3.6.0-4 jsch:0.1.55.61.va_e9ee26616e7 junit:1119.1121.vc43d0fc45561 kubernetes:3697.v771155683e38 kubernetes-client-api:5.12.2-193.v26a_6078f65a_9 kubernetes-credentials:0.9.0 kubernetes-credentials-provider:1.196.va_55f5e31e3c2 last-changes:2.7.11 mailer:435.v79ef3972b_5c7 mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:2.6.6 matrix-project:772.v494f19991984 maven-plugin:3.19 metrics:4.2.10-389.v93143621b_050 miniorange-saml-sp:1.0.11 momentjs:1.1.1 node-iterator-api:1.5.1 nodejs:1.5.1 nvm-wrapper:0.1.7 oauth-credentials:0.5 oic-auth:1.8 okhttp-api:4.9.3-108.v0feda04578cf parameter-separator:1.3 parameterized-trigger:2.45 pipeline-aws:1.43 pipeline-build-step:2.18 pipeline-github:2.8-138.d766e30bb08b pipeline-graph-analysis:195.v5812d95a_a_2f9 pipeline-groovy-lib:612.v84da_9c54906d pipeline-input-step:449.v77f0e8b_845c4 pipeline-milestone-step:101.vd572fef9d926 pipeline-model-api:2.2114.v2654ca_721309 pipeline-model-definition:2.2114.v2654ca_721309 pipeline-model-extensions:2.2114.v2654ca_721309 pipeline-rest-api:2.24 pipeline-stage-step:293.v200037eefcd5 pipeline-stage-tags-metadata:2.2114.v2654ca_721309 pipeline-stage-view:2.24 pipeline-utility-steps:2.13.0 plain-credentials:139.ved2b_9cf7587b plugin-usage-plugin:3.0 plugin-util-api:2.17.0 popper2-api:2.11.5-2 prism-api:1.28.0-2 pubsub-light:1.16 rebuild:1.34 resource-disposer:0.19 role-strategy:555.v8d194cc85b_30 saferestart:0.3 scm-api:621.vda_a_b_055e58f7 scm-filter-branch-pr:0.5.1 script-security:1175.v4b_d517d6db_f0 slack:616.v03b_1e98d13dd snakeyaml-api:1.30.2-76.vc104f7ce9870 sonar:2.14 sse-gateway:1.25 ssh-credentials:295.vced876c18eb_4 sshd:3.0.3 structs:324.va_f5d6774f3a_d subversion:2.16.0 test-results-analyzer:0.3.5 timestamper:1.18 token-macro:308.v4f2b_ed62b_b_16 trilead-api:1.67.vc3938a_35172f uno-choice:2.6.3 variant:59.vf075fe829ccb windows-slaves:1.8.1 workflow-aggregator:590.v6a_d052e5a_a_b_5 workflow-api:1192.v2d0deb_19d212 workflow-basic-steps:991.v43d80fea_ff66 workflow-cps:2759.v87459c4eeaca workflow-durable-task-step:1199.v02b_9244f8064 workflow-job:1207.ve6191ff089f8 workflow-multibranch:716.vc692ae52371b workflow-scm-step:400.v6b_89a1317c9a workflow-step-api:639.v6eca_cd8c04aa workflow-support:838.va_3a_087b_4055b ws-cleanup:0.42

What Operating System are you using (both controller, and any agents involved in the problem)?

google/cloud-sdk:alpine

Reproduction steps

When specifying a path with no file as option for plugin

  path: no-files-in-path

Only error prompt is being shown but no error is being thrown and exit status looks ok:

[Pipeline] googleStorageUpload
09:43:46  ERROR: [Google Cloud Storage Plugin] No artifacts found matching pattern: no-files-in-path

Expected Results

Exit status should not be 0, exception / error should be thrown

Actual Results

Only error prompt is being shown but no error is being thrown and exit status looks ok

Anything else?

No response

shadygm commented 9 months ago

Hi, Has there been any progress or further information about this? Thanks