jenkinsci / google-storage-plugin

This plugin provides the “Google Cloud Storage Uploader” post-build step for publishing build artifacts to Google Cloud Storage.
https://plugins.jenkins.io/google-storage-plugin/
Apache License 2.0
31 stars 57 forks source link

Ensure include FilePath in Windows has normalized separators #306

Open AbrilRBS opened 2 months ago

AbrilRBS commented 2 months ago

The issue and explanation is laid out in https://github.com/jenkinsci/google-storage-plugin/issues/305#issuecomment-2186516763 I'm creating this PR in hopes it helps anyone else facing the same issue.

I understand that the code might might not be fully production ready, or that a better approach might exist, I'd be happy to work towards a better solution after some guidance :)

Closes https://github.com/jenkinsci/google-storage-plugin/issues/305

Testing done

This was tested by running Jenkins with the compiled plugin and validating that a file was in fact uploaded. Before this change, we got a stacktrace when running in Windows. After, we have a file in our bucket. I can provide screenshots of the before/after if needed but would need to be heavily censored

Submitter checklist