Allow tweaking WAR generation from consumers

jenkinsci / gradle-jpi-plugin

Build Jenkins Plugins with Gradle

79 stars 50 forks source link

Allow tweaking WAR generation from consumers #193

Closed jamietanna closed 2 years ago

jamietanna commented 2 years ago

Dependencies

N/A

Feature Request

Currently, the Job DSL Plugin attempts to copy files into the produced WAR.

This doesn't work, as we have a hardcoded directory configured for the WAR configuration

Causes https://issues.jenkins.io/browse/JENKINS-66988

sghill commented 2 years ago

Hi @jamietanna, this should already be possible. I created jenkinsci/job-dsl-plugin#1244 to demonstrate how.

jenkinsci/gradle-jpi-plugin@4f4495a (first released in v0.39.0 of the jpi plugin) stopped applying the war plugin in favor of defining a jpi task that was of type War. Configuring task jpi instead of war should be all that's needed.

Thanks for raising this issue. It was missing from the migration guide (#139) and has since been added.

jamietanna commented 2 years ago

Closing, as this is a good fix for it, appreciate the PR and help :raised_hands: