Add a flag to disable adding timestamp to the SNAPSHOT version

c00ler commented 1 year ago

This PR adds a flag that allows to opt-out from adding the timestamp to the -SNAPSHOT version in the Jenkins manifest file. Since the default value for the new flag is true there are no changes to the build. Users have to configure it explicitly. As mentioned in the comment the current behavior doesn't allow Gradle to cache the results and causes all the dependent tasks always to be executed.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

sghill commented 1 year ago

Thanks for the contribution @c00ler! Wanted to let you know I should be able to get to this by early next week.

Not sure if nebula.release is a suitable alternative for your use case, but this is what I use to avoid the caching problem today.

sghill commented 1 year ago

@c00ler I published 0.48.0-rc.1 with this change. If all goes well I'll publish 0.48.0 in the next couple weeks.

c00ler commented 1 year ago

@c00ler I published 0.48.0-rc.1 with this change. If all goes well I'll publish 0.48.0 in the next couple weeks.

Thank you for letting me know! Happy New Year!

sghill commented 1 year ago

0.48.0 was released today with this change. Sorry for the delay, and thanks again for the contribution!

jenkinsci / gradle-jpi-plugin

Add a flag to disable adding timestamp to the SNAPSHOT version #210