Closed alextu closed 1 year ago
Thanks so much for following up on this @alextu. Getting these contributions is wonderful.
One question on this line - should we support windows too by using String.format("%n")
?
I have released this change as 0.49.0-rc.2 today.
Thanks so much for following up on this @alextu. Getting these contributions is wonderful.
One question on this line - should we support windows too by using
String.format("%n")
?I have released this change as 0.49.0-rc.2 today.
Thanks! Good catch, I will submit a PR to fix this
This is another follow up of https://github.com/jenkinsci/gradle-jpi-plugin/issues/215 that is not sufficient to publish incrementals when running on ci.jenkins.io (hopefully the last one ?).
It requires first to have
<tag>...</tag>
set in the published pom with the full git hash. This PR changes thegenerateGitVersionTask
to also set the full Git hash in theversion.txt
in addition to the formatted one. It also adds ascmTag
property to theJpiExtension
that can be set via a Gradle property. Eventually the https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildPluginWithGradle.groovy will do something like-PscmTag=${versionFile.readLines()[1]}
Optionally users should be able to add a version prefix to the generate version, like a "major.minor" for example, ending up with for example
1.0-rc1.abcdef
or a real world example: https://ci.jenkins.io/job/Plugins/job/git-plugin/job/master/ This PR adds an optionalversionPrefix
to theGitVersionExtension
[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue