search

jenkinsci / groovy-events-listener-plugin

A Jenkins plugin, which executes groovy code when an event occurs.
https://plugins.jenkins.io/groovy-events-listener-plugin/
MIT License
36 stars 34 forks source link

Update Groovy to 2.4.12 #53

Closed krische closed 4 years ago

krische commented 4 years ago

Fixes #49

Changes proposed

Checklist

Notify

@markyjackson-taulia

darxriggs commented 4 years ago

This pull request follows #50 which missed to change required settings and therefore the HPI file still contains Groovy 2.4.8.

markjacksonfishing commented 4 years ago

@darxriggs Something is wrong with ci again. Can you refire this PR to kick off the job again

darxriggs commented 4 years ago

@markyjackson-taulia it's not my pull request so I cannot do so. You can close it, wait for some seconds, reopen it. Then ci.jenkins.io will be triggered again.

darxriggs commented 4 years ago

@krische let's wait some time for an answer from @nickgrealy and then adapt the pull request accordingly.

After the above investigations my goal would be to get rid of forceGroovy completely. Otherwise the plugin would hit the same problem (2 different Groovy versions) from time to time again. I just tested with Jenkins LTS 2.204.1 which provides Groovy 2.4.12 and a custom plugin version which for example provides Groovy 2.4.17.

markjacksonfishing commented 4 years ago

Leaving this as WIP until we have consensus

darxriggs commented 4 years ago

@krische Could you update the pull request with the slight adaptions I suggested or is there still something from your side to discuss?

darxriggs commented 4 years ago

@krische Do you know when you will have time to go on with this or should I take over?

As I lately also cleaned up the Gradle files in #60 there are now also merge conflicts to be resolved.

krische commented 4 years ago

@darxriggs I don't have time to work on this soon, if you want to take over that would be great.

darxriggs commented 4 years ago

@krische Ok. I'll create a new pull request and add you as co-author to pay some contribution.

krische commented 4 years ago

@darxriggs Should I close this one then?

darxriggs commented 4 years ago

@krische Yes, please close it. It is superseded by #61.

AlbanAndrieu commented 4 years ago

Thanks @darxriggs . Working on jenkins 2.204.3