jenkinsci / groovy-events-listener-plugin

A Jenkins plugin, which executes groovy code when an event occurs.
https://plugins.jenkins.io/groovy-events-listener-plugin/
MIT License
36 stars 34 forks source link

Remove `synchronized` keyword from GlobalEventsPlugin #8

Closed nickgrealy closed 8 years ago

nickgrealy commented 8 years ago

Currently the execution of the safeExecGroovyCode method is synchronized, to ensure the groovy code is executed in a thread safe manner.

This behaviour causes a minor performance issue, and may not be desirable in some cases.

Therefore, rather than forcing it on the user, we've opted to leave the implementation of the groovy code execution, up to the end user.

(It was originally added to pre-empt issues. Instead we'll remove, until there's general/common need for it.)