### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
In our analysis of the project, we observed that
1) 3 unnecessary stubbings which stubbed getRoleId method, getSecretId method, and authorizeWithVault method in createTokenCredential are created but are never executed by some method calls in FolderIT.setupJenkins.
2) 5 unnecessary stubbings which stubbed getId method,getDescription method,getRoleId method, getSecretId method, and authorizeWithVault method in createTokenCredential are created but are never executed by some method calls in FolderIT.setupJenkins.
3) 4 unnecessary stubbings which stubbed getData method,getRestResponse method,getStatus method, read method in mockVaultAccessor are created but are never executed by some tests: VaultConfigurationIT.shouldFailIfCredentialsNotConfigured, VaultConfigurationIT.shouldFailIfUrlNotConfigured,VaultConfigurationIT.shouldFailIfNoConfigurationExists, VaultConfigurationIT.shouldFailIfCredentialsDoNotExist.
Testing done
In our analysis of the project, we observed that 1) 3 unnecessary stubbings which stubbed
getRoleId
method,getSecretId
method, andauthorizeWithVault
method increateTokenCredential
are created but are never executed by some method calls inFolderIT.setupJenkins
.2) 5 unnecessary stubbings which stubbed
getId
method,getDescription
method,getRoleId
method,getSecretId
method, andauthorizeWithVault
method increateTokenCredential
are created but are never executed by some method calls inFolderIT.setupJenkins
.3) 4 unnecessary stubbings which stubbed
getData
method,getRestResponse
method,getStatus
method,read
method inmockVaultAccessor
are created but are never executed by some tests:VaultConfigurationIT.shouldFailIfCredentialsNotConfigured
,VaultConfigurationIT.shouldFailIfUrlNotConfigured
,VaultConfigurationIT.shouldFailIfNoConfigurationExists
,VaultConfigurationIT.shouldFailIfCredentialsDoNotExist
.Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.