jenkinsci / hashicorp-vault-plugin

Jenkins plugin to populate environment variables from secrets stored in HashiCorp's Vault.
https://plugins.jenkins.io/hashicorp-vault-plugin/
MIT License
217 stars 143 forks source link

Rename tokenExpiry field to prevent Folder corruption issues when upgrading from old versions of this plugin #336

Closed dwnusbaum closed 1 week ago

dwnusbaum commented 2 weeks ago

XStream attempts to deserialize all fields in XML files that have a corresponding field in the class, even if it is marked transient. This means that #325 did not actually fix the issues described in #323, #324, and #326, which were caused by #223.

This should fix #323, #324, and #326. I tested it manually with a corrupted folder.

Testing done

Submitter checklist

bluesliverx commented 2 weeks ago

I'm not sure who has merge permissions here, but I do not.

dwnusbaum commented 2 weeks ago

@jetersen Any chance you can help get this released?