jenkinsci / helm-charts

Jenkins helm charts
https://artifacthub.io/packages/helm/jenkinsci/jenkins
Apache License 2.0
561 stars 889 forks source link

Secondary Ingress template should be same as Main Ingress template #476

Open EyalZilberblum opened 3 years ago

EyalZilberblum commented 3 years ago

Describe the bug Secondary Ingress template should have the same structure as Main Ingress template, enabling full customization of the ingress controller.

Version of Helm and Kubernetes:

Helm Version:

$ helm version
version.BuildInfo{Version:"v3.5.3", GitCommit:"041ce5a2c17a58be0fcd5f5e16fb3e7e95fea622", GitTreeState:"dirty", GoVersion:"go1.16"}

Kubernetes Version:

$ kubectl version
lient Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.4-dirty", GitCommit:"e87da0bd6e03ec3fea7933c4b5263d151aafd07c", GitTreeState:"dirty", BuildDate:"2021-03-15T10:03:32Z", GoVersion:"go1.16.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.2-eks-0389ca3", GitCommit:"8a4e27b9d88142bbdd21b997b532eb6d493df6d2", GitTreeState:"clean", BuildDate:"2021-07-31T01:34:46Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"}

Which version of the chart: 3.5.11

What happened: Secondary Ingress template dont support entire ingress configuration

What you expected to happen: Secondary Ingress template to support entire ingress configuration (all attributes should be configurable) preferably allow to configure the entire 'paths' block

How to reproduce it (as minimally and precisely as possible): Try to configure Secondary ingress same way as the main Ingress Or Try to Set on secondary insgress path: pathType: Prefix

Anything else we need to know:

torstenwalter commented 2 years ago

@EyalZilberblum feel free to create a PR to address the issue you are describing.

EyalZilberblum commented 2 years ago

@torstenwalter baking something, will make a PR available soon

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.