search

jenkinsci / idea-stapler-plugin

Jenkins Development Support for IntelliJ IDEA
https://plugins.jetbrains.com/plugin/1885-jenkins-development-support/
BSD 2-Clause "Simplified" License
9 stars 20 forks source link

Add Apache Commons JEXL support #18

Open duemir opened 4 years ago

duemir commented 4 years ago

JEXL is a full expression language. It would be great to have full language support like JavaEE Expression Language or Spring EL.

This epic size. There are lots of parts to language support. The JEXL parser is defined with JavaCC which do not have any bridge to JetBrains GrammarKit so the whole grammar needs to be replicated.

https://commons.apache.org/proper/commons-jexl/ upstream https://github.com/jenkinsci/jexl Jenkins fork https://www.jetbrains.org/intellij/sdk/docs/reference_guide/custom_language_support.html relevant docs

jgreffe commented 2 years ago

Hello, do we have any idea of the purpose of fork https://github.com/jenkinsci/jexl compared to upstream https://github.com/apache/commons-jexl ?

I see only these additional commits on upstream (not part of fork) when comparing sources between https://github.com/apache/commons-jexl/tree/1.x and https://github.com/jenkinsci/jexl https://github.com/apache/commons-jexl/commit/107d93b1a4d5a4e465ffebf8ee46890bab5e6ebb https://github.com/apache/commons-jexl/commit/0664d10252cd1db6c45132349b6b9c8654722989

Or is the fork patched branch the one to rely on, and in this case there are more differences.

duemir commented 2 years ago

@jgreffe, I have no idea. Some old-time core developers might have some thoughts about it.