jenkinsci / ivy-plugin

Jenkins ivy plugin
https://plugins.jenkins.io/ivy/
MIT License
16 stars 42 forks source link

still using deprecated config-publishers jelly breaks project config pages #47

Closed aldennisa15 closed 1 year ago

aldennisa15 commented 1 year ago

Jenkins and plugins versions report

Environment ```text Jenkins: 2.346.3 OS: Linux - 4.18.0-372.26.1.el8_6.x86_64 --- ace-editor:1.1 all-changes:1.5 analysis-model-api:10.17.0 ant:481.v7b_09e538fcca antisamy-markup-formatter:2.7 apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61 authentication-tokens:1.4 bootstrap4-api:4.6.0-5 bootstrap5-api:5.2.1-2 bouncycastle-api:2.26 branch-api:2.1046.v0ca_37783ecc5 bugzilla:1.5 build-symlink:1.1 build-timeout:1.24 caffeine-api:2.9.3-65.v6a_47d0f4d1fe checks-api:1.7.5 claim:495.v01a_c6fb_2b_a_7a cloudbees-folder:6.740.ve4f4ffa_dea_54 cobertura:1.17 code-coverage-api:3.1.0 command-launcher:90.v669d7ccb_7c31 conditional-buildstep:1.4.2 config-file-provider:3.11.1 copyartifact:1.47 create-fingerprint:1.2 credentials:1143.vb_e8b_b_ceee347 credentials-binding:523.vd859a_4b_122e6 cucumber-reports:5.7.3 cvs:2.19.1 cvs-tag:1.7 dashboard-view:2.447.vda_124dd35f11 data-tables-api:1.12.1-3 depgraph-view:1.0.5 description-setter:1.10 disk-usage:0.28 display-url-api:2.3.6 docker-commons:1.21 docker-workflow:521.v1a_a_dd2073b_2e durable-task:500.v8927d9fd99d8 echarts-api:5.3.3-1 email-ext:2.91 envinject-api:1.199.v3ce31253ed13 external-monitor-job:203.v683c09d993b_9 font-awesome-api:6.2.0-3 forensics-api:1.16.0 fstrigger:1.00 git:4.12.1 git-client:3.12.0 git-server:1.11 github:1.34.5 github-api:1.303-400.v35c2d8258028 github-branch-source:1695.v88de84e9f6b_9 gitlab-plugin:1.5.35 handlebars:3.0.8 ionicons-api:24.va_745a_b_a_97fc3 ivy:2.2 jackson2-api:2.13.3-285.vc03c0256d517 jakarta-activation-api:2.0.1-1 jakarta-mail-api:2.0.1-1 javadoc:226.v71211feb_e7e9 javax-activation-api:1.2.0-4 javax-mail-api:1.6.2-7 jaxb:2.3.6-1 jdk-tool:55.v1b_32b_6ca_f9ca jersey2-api:2.37-1 jjwt-api:0.11.5-77.v646c772fddb_0 jnr-posix-api:3.1.15-1 jobConfigHistory:1176.v1b_4290db_41a_5 join:1.21 jquery:1.12.4-1 jquery-detached:1.2.1 jquery3-api:3.6.1-1 jsch:0.1.55.61.va_e9ee26616e7 junit:1143.v8d9a_e3355270 ldap:2.12 lockable-resources:2.16 log-parser:2.2 mailer:435.v79ef3972b_5c7 mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:3.1.5 matrix-project:772.v494f19991984 maven-plugin:3.19 mercurial:1251.va_b_121f184902 mina-sshd-api-common:2.9.1-44.v476733c11f82 mina-sshd-api-core:2.9.1-44.v476733c11f82 momentjs:1.1.1 nested-view:1.19.2 npm-yarn-wrapper-steps:0.4.0 okhttp-api:4.9.3-108.v0feda04578cf pam-auth:1.10 parameterized-trigger:2.45 pipeline-build-step:2.18 pipeline-github-lib:38.v445716ea_edda_ pipeline-graph-analysis:195.v5812d95a_a_2f9 pipeline-groovy-lib:612.v84da_9c54906d pipeline-input-step:451.vf1a_a_4f405289 pipeline-milestone-step:101.vd572fef9d926 pipeline-model-api:2.2114.v2654ca_721309 pipeline-model-definition:2.2114.v2654ca_721309 pipeline-model-extensions:2.2114.v2654ca_721309 pipeline-rest-api:2.24 pipeline-stage-step:296.v5f6908f017a_5 pipeline-stage-tags-metadata:2.2114.v2654ca_721309 pipeline-stage-view:2.24 plain-credentials:139.ved2b_9cf7587b plugin-usage-plugin:3.0 plugin-util-api:2.17.0 popper-api:1.16.1-3 popper2-api:2.11.6-1 prism-api:1.29.0-1 promoted-builds:892.vd6219fc0a_efb radiatorviewplugin:1.29 resource-disposer:0.20 run-condition:1.5 scm-api:621.vda_a_b_055e58f7 script-security:1183.v774b_0b_0a_a_451 slack:625.va_eeb_b_168ffb_0 snakeyaml-api:1.32-86.ve3f030a_75631 ssh-agent:295.v9ca_a_1c7cc3a_a_ ssh-credentials:305.v8f4381501156 ssh-slaves:1.834.v622da_57f702c sshd:3.242.va_db_9da_b_26a_c3 structs:324.va_f5d6774f3a_d subversion:2.16.0 throttle-concurrents:2.9 timestamper:1.20 token-macro:308.v4f2b_ed62b_b_16 translation:1.16 trilead-api:1.67.vc3938a_35172f variant:59.vf075fe829ccb versioncolumn:2.2 view-job-filters:2.3 warnings-ng:9.20.0 windows-slaves:1.8.1 workflow-aggregator:590.v6a_d052e5a_a_b_5 workflow-api:1192.v2d0deb_19d212 workflow-basic-steps:994.vd57e3ca_46d24 workflow-cps:2759.v87459c4eea_ca_ workflow-cps-global-lib:588.v576c103a_ff86 workflow-durable-task-step:1199.v02b_9244f8064 workflow-job:1207.ve6191ff089f8 workflow-multibranch:716.vc692a_e52371b_ workflow-scm-step:400.v6b_89a_1317c9a_ workflow-step-api:639.v6eca_cd8c04a_a_ workflow-support:838.va_3a_087b_4055b ws-cleanup:0.43 xtrigger-api:0.4 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

OS: Linux - 4.18.0-372.26.1.el8_6.x86_64

Reproduction steps

attempt to modify an existing ivy job

Expected Results

page not messed up. changes can be saved

Actual Results

the config page is messed up and changes can't be saved

Anything else?

plugin uses config-publishers and publishers.rebuild. These are deprecated - see https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html#lib-hudson-project

patch that appears to fix it is attached - it's pretty simple (works for me) - but probably needs a jelly expert to give it the once over 0001-update-from-config-publishers-to-config-publishers2-.patch.txt

basil commented 1 year ago

Released in 2.4.