search

jenkinsci / jenkins-test-harness

Unit test framework for Jenkins core and its plugins
https://www.jenkins.io/doc/developer/testing/
MIT License
109 stars 126 forks source link

Limiting `ProcessTree.killAll` to `InboundAgentRule.after` #802

Closed jglick closed 3 months ago

jglick commented 3 months ago

https://github.com/jenkinsci/jenkins-test-harness/pull/795#issuecomment-2219071287 I neglected to consider direct call to InboundAgentRule.stop from test code, which should not kill subprocesses, only the agent JVM itself. Tested in workflow-durable-task-step on all test cases in AgentErrorConditionTest & ExecutorStepTest; also verified that the proprietary test suite originally motivating #795 continues to pass with this, and that subprocesses are still terminated at the end of the test.

basil commented 3 months ago

Thank you very much! Confirming that my Jetty 12 test matrix is back to green after this PR.