search

jenkinsci / jenkins.rb

Deprecated, see https://www.jenkins.io/jep/7
393 stars 83 forks source link

[JENKINS-48116] Proxy to StreamTaskListener not AbstractTaskListener #122

Closed jglick closed 7 months ago

jglick commented 6 years ago

An equivalent patch made directly to rvm.hpi allows https://github.com/jenkinsci/acceptance-test-harness/pull/383 to pass even without https://github.com/jenkinsci/jenkins/pull/3154. But I suppose this gem would need to be released and then every plugin with a dependency on ruby-runtime rebuilt in order for the fix to actually take effect. Yuck.

@reviewbybees

oleg-nenashev commented 6 years ago

Probably it could be reworked to API Plugin if there is somebody who has lost of spare time for that.

ghost commented 6 years ago

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

jglick commented 6 years ago

Yeah I would have expected the gem to be packaged in the ruby-runtime plugin itself. But the gem has apparently not been released since 2012, and acc. to

curl -sL https://updates.jenkins-ci.org/update-center.json | head -2 | tail +2 | jq -r '.plugins | .[] | select(.dependencies | .[] | .name == "ruby-runtime") | .name'

there are 23 plugins using this dependency. Seems like a serious maintainability issue.

jglick commented 6 years ago

@reviewbybees done

jglick commented 6 years ago

@daniel-beck note that when JEP-7 is implemented, this could be closed (along with any other PRs to this repo).