search

jenkinsci / jenkins.rb

Deprecated, see https://www.jenkins.io/jep/7
393 stars 83 forks source link

Change to use rubyzip 1.1.0 or newer #95

Closed eitoball closed 10 years ago

eitoball commented 10 years ago

jpi build command fails like following:

$ jpi build
LoadError: no such file to load -- zip/zip
         require at org/jruby/RubyKernel.java:1084
         require at /Users/eito/Library/Homebrew/Cellar/rbenv/0.4.0/versions/jruby-1.7.8/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:55
         require at /Users/eito/Library/Homebrew/Cellar/rbenv/0.4.0/versions/jruby-1.7.8/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:53
          (root) at /Users/eito/Library/Homebrew/opt/rbenv/versions/jruby-1.7.8/gemsets/rvm-plugin/gems/jpi-0.3.8/lib/jenkins/plugin/tools/package.rb:3
         require at org/jruby/RubyKernel.java:1084

This is because jpi picks up the latest rubyzip gem (1.1.0 at this moment) and the gem has changed several things.

This PR should fix this issue to cope with those changes in rubyzip gem.

hsbt commented 10 years ago

Thank you. I'll release to jpi-0.3.9 or 0.4.0 after triage of issues.

daniilyar commented 10 years ago

Is this update already released? I could not release my fork of https://github.com/daniilyar/jenkins-ci-skip-plugin/blob/master/README.md jenkins plugin because of the same exception.

hsbt commented 10 years ago

@daniilyar Thank you for your ping, I forgot to release of new version. Just pushed v0.4.0. Please confirm it.

daniilyar commented 10 years ago

Yes, exception gone in 0.4.0 version, thank you!