Pin Jenkinsfile Runner versions in demos

jenkinsci / jenkinsfile-runner

A command line tool to run Jenkinsfile as a function

MIT License

1.13k stars 291 forks source link

Pin Jenkinsfile Runner versions in demos #261

Open oleg-nenashev opened 4 years ago

oleg-nenashev commented 4 years ago

Currently Jenkinsfile Runner demos use the runner version from the local repository. So each demo basically needs an update every time an incompatible version is released. It would be better to support delaying the demo updates by using an explicit Jenkinsfile Runner version definitions in all Custom War Packager config files

sladyn98 commented 4 years ago

+1 to this change, but that would mean manually pinning every jenkinsfile runner demo, or we would just pin it here and then the resultant demos will then pick it up . https://github.com/jenkinsci/custom-war-packager/blob/3aa29ed5432051198b9de410223732cc21843f36/demo/jenkinsfile-runner/Makefile#L5 --> This version seems to be fixed, am I missing something here ?