search

jenkinsci / jenkinsfile-runner

A command line tool to run Jenkinsfile as a function
MIT License
1.13k stars 292 forks source link

Removing JSR 250 `@PostConstruct` #526

Closed jglick closed 3 years ago

jglick commented 3 years ago

Rather than #522, simply removing this annotation. I think it was probably unused, seeing as this method was already being explicitly called even in #21, and still is: https://github.com/jenkinsci/jenkinsfile-runner/blob/e76a4461a5f38d02d27d196cb600a6448431867e/bootstrap/src/main/java/io/jenkins/jenkinsfile/runner/bootstrap/commands/JenkinsLauncherCommand.java#L67 https://github.com/jenkinsci/jenkinsfile-runner/blob/e76a4461a5f38d02d27d196cb600a6448431867e/bootstrap/src/main/java/io/jenkins/jenkinsfile/runner/bootstrap/Bootstrap.java#L61

jglick commented 3 years ago

I hope there is test coverage for this?

oleg-nenashev commented 3 years ago

I hope there is test coverage for this?

We are in Beta 🤷