Force to PERFORMANCE_OPTIMIZED for Pipeline execution

abayer commented 3 years ago

For some reason, disabling resume isn't doing what I would have expected, i.e., leading to PERFORMANCE_OPTIMIZED being used as the durability level. So hey, let's be a little heavy-handed and just set the durability hint for the newly-created job directly.

This also resulted in my IDE cleaning up Runner.java's imports and I decided to allow it.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

abayer commented 3 years ago

@oleg-nenashev Turns out I was confused and reading test case output of a plugin, not JFR output. Blocking resume did do the trick, but I don't think keeping this in would have a downside anyway. It just makes dang sure it uses PERFORMANCE_OPTIMIZED. =)

oleg-nenashev commented 3 years ago

Yeah. No problem for keeping it explicit. And thanks for checking!

On Wed, Jun 23, 2021, 22:03 Andrew Bayer @.***> wrote:

@oleg-nenashev https://github.com/oleg-nenashev Turns out I was confused and reading test case output of a plugin, not JFR output. Blocking resume did do the trick, but I don't think keeping this in would have a downside anyway. It just makes dang sure it uses PERFORMANCE_OPTIMIZED. =)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/jenkinsfile-runner/pull/529#issuecomment-867121141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW4RID2L6V3AZBR65Z3YADTUI423ANCNFSM47GHRZTA .

jenkinsci / jenkinsfile-runner

Force to PERFORMANCE_OPTIMIZED for Pipeline execution #529