search

jenkinsci / jfrog-plugin

The Jenkins JFrog Plugin allows for easy integration between Jenkins and the JFrog Platform.
https://github.com/jfrog/jenkins-jfrog-plugin
Apache License 2.0
10 stars 24 forks source link

proxy support breaks nodes configuration #14

Open toinux opened 1 year ago

toinux commented 1 year ago

Describe the bug

Hello,

I use the jenkins master with a local proxy server (127.0.0.1:8080) to fetch plugins from outside of the local network. Artifactory is running on a local server, so no proxy needed in this case.

commit 3448dd9 forces nodes to inherit from controller proxy configuration and breaks at least jfrog client automatic installation.

Is it possible to add an option to disable proxy configuration, or eventually a no_proxy parameter to whitelist hosts on local network ?

Thank you.

Current behavior

Nodes try to connect to proxy 127.0.0.1:8080 which exists only on jenkins master.

Reproduction steps

No response

Expected behavior

No response

JFrog plugin version

1.2.0

JFrog CLI version

latest

Operating system type and version

rhel7

JFrog Artifactory version

No response

JFrog Xray version

No response

yahavi commented 1 year ago

@toinux We recently released Jenkins JFrog plugin 1.5.0. This version includes support for "No proxy hosts". Just add "127.0.0.1" to the "No proxy hosts". Read more about it under Using HTTP/S Proxy.

We'd appreciate any feedback on that.