search

jenkinsci / jira-plugin

Jenkins jira plugin
https://plugins.jenkins.io/jira
MIT License
168 stars 282 forks source link

Clean up HTTP authentication code references #541

Open rantoniuk opened 1 year ago

rantoniuk commented 1 year ago

Clean up HTTP Auth references from the code based on the discussion in https://github.com/jenkinsci/jira-plugin/pull/521#discussion_r1193185025_

akshaywakhare commented 1 year ago

Hi. I would like to give this a try, can I work on this?

rantoniuk commented 1 year ago

Of course, you're welcome to contribute!

xRME-18 commented 1 year ago

Hey, what should be done with all the (deprecated) functions using useHTTPAuth? Should I update the functions with useBearerAuth or remove them entirely? Sorry if its obvious, I'm new to this.

programbeginnerTW commented 1 year ago

Hi, I looked through the mentioned issue above and concluded the disscussion:

  1. Bearer Authentication is only allowed on Jira Server but not on Jira cloud.
  2. HTTP auth as well as Bearer auth should both exist to meet the requirements of 1.

Hence, I removed the invisibleEntry section of HTTP in the config.jelly file and updated the constructors in file JiraSite.java, as well as the JiraSiteTest.java by adding useBearerAuth. If I'm misunderstanding the issue, please offer more instructions on how I can contribute to this issue, thanks!

Here is my Pull Request: https://github.com/jenkinsci/jira-plugin/pull/562

abhishekshah5486 commented 2 months ago

I would like to work on this issue. Please assign this issue to me.