jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 38 forks source link

Message properties should do variable substitution on entire set of properties, not by line. #133

Closed ggallen closed 5 years ago

ggallen commented 5 years ago

Currently substitution in the message properties is done on a line-by-line basis. So the plugin loops through the lines in the property text and performs substitution on each.

This doesn't work when the entire message properties field is ${MESSAGE_PROPERTIES}.

In this case, the user set a job parameter named MESSAGE_PROPERTIES to the list of properties to be used on that particular job run. And the way it's coded now, now substitution was done and the message headers contained the string "${MESSAGE_PROPERTIES}".

The substitution for the properties should be done just as the message body is done, on the entire value.

ggallen commented 5 years ago

Fixed by https://github.com/jenkinsci/jms-messaging-plugin/pull/136.