search

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 38 forks source link

Prevent deadlock when saving a pipeline job #144

Open carlossg opened 5 years ago

carlossg commented 5 years ago

When using the trigger in a pipeline and saving the job configuration the thread stop/start methods are called twice causing an InterruptedException most times (in a small setup) which leaves the page loading hanging and the thread running in the receive() method

scoheb commented 5 years ago

So the test failure here: https://ci.jenkins.io/job/Plugins/job/jms-messaging-plugin/job/PR-144/1/testReport/junit/com.redhat.jenkins.plugins.ci.integration/AmqMessagingPluginWithFailoverIntegrationTest/testSimpleCIEventTrigger/ is actually not a failure anymore...but the test should be amended?

carlossg commented 5 years ago

the number of threads is 0 when the test fails, so the check for 2 threads different is wrong There are a lot of unable to connect to messages in the log But I'm not able to run the tests locally