search

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 38 forks source link

Correct handling of Boolean Parameters during triggering #152

Closed scoheb closed 4 years ago

scoheb commented 4 years ago

Fixes #141

ggallen commented 4 years ago

I think I understand what you are doing, but fedmsg doesn't have any concept of message headers. So I assume you are forcing any parameters to behave as headers?

scoheb commented 4 years ago

@ggallen Looking at datagrepper for Fedora (https://apps.fedoraproject.org/datagrepper/id?id=2019-6e63976f-9b4e-4f1d-941e-d950babe8b32&is_raw=true&size=extra-large) there is a headers element...I am using that.

ggallen commented 4 years ago

That's something added by datagrepper. It's not part of the actual message at all. Just as the "msg" element isn't really part of the message, but datagrepper adds that and puts the body of the message under it.

This solution may work, and may be the only way to do it. But I'm not sure it's the right way. I don't think job parameters for AMQ messages get put in the message headers. Or do they?

scoheb commented 4 years ago

@ggallen maybe it is not applicable for FedMsg...but it is working...

it has always worked for ActiveMQ for String parameters...I fixed it to work with Booleans