search

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 38 forks source link

Add support for Fedora messaging wire format #162

Closed Zlopez closed 4 years ago

Zlopez commented 4 years ago

Fedora messaging recently introduced wire format (see https://fedora-messaging.readthedocs.io/en/latest/wire-format.html). This commit adds support for the new headers.

Signed-off-by: Michal Konečný mkonecny@redhat.com

scoheb commented 4 years ago

please rebase

Zlopez commented 4 years ago

Rebased

scoheb commented 4 years ago

There are test failures. Can you please review them?

Zlopez commented 4 years ago

Where can I look at the specific failures?

scoheb commented 4 years ago

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fjms-messaging-plugin/detail/PR-162/3/pipeline

Zlopez commented 4 years ago

Sorry, didn't noticed the correct step. Looking at it, this doesn't look like these errors are related to changes in this PR.

[2020-02-21T08:58:45.503Z] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 326.961 s <<< FAILURE! - in com.redhat.jenkins.plugins.ci.integration.AmqMessagingPluginLockdownIntegrationTest
[2020-02-21T08:58:45.503Z] [ERROR] com.redhat.jenkins.plugins.ci.integration.AmqMessagingPluginLockdownIntegrationTest.testBlockNonAdminAccess  Time elapsed: 326.875 s  <<< ERROR!
[2020-02-21T08:58:45.503Z] java.lang.IllegalArgumentException: jms-messaging plugin not installed
[2020-02-21T08:58:45.503Z] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 326.961 s <<< FAILURE! - in com.redhat.jenkins.plugins.ci.integration.AmqMessagingPluginLockdownIntegrationTest
[2020-02-21T08:58:45.503Z] [ERROR] com.redhat.jenkins.plugins.ci.integration.AmqMessagingPluginLockdownIntegrationTest.testBlockNonAdminAccess  Time elapsed: 326.875 s  <<< ERROR!
[2020-02-21T08:58:45.503Z] java.lang.IllegalArgumentException: jms-messaging plugin not installed

This looks like some temporary error with plugin installation.

Zlopez commented 4 years ago

@scoheb I did a force push to restart the tests and now everything ended with success.

scoheb commented 4 years ago

Released in version 1.1.14