Move ath to module to escape the dependency hell

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging

12 stars 38 forks source link

Move ath to module to escape the dependency hell #164

Closed olivergondza closed 4 years ago

olivergondza commented 4 years ago

This is a PoC downstream PR for jenkinsci/acceptance-test-harness#556

olivergondza commented 4 years ago

@scoheb, @ggallen, this is ready to be merged once the tests are passing. Can you please have a look?

olivergondza commented 4 years ago

@scoheb, @ggallen, pretty please

scoheb commented 4 years ago

looks awesome. do we need a small tip on running this ui-tests? simple mvn test?

olivergondza commented 4 years ago

Might require mvn package (not sure) and running docker daemon. That should be it.

scoheb commented 4 years ago

I was able to run a subset of tests locally with success.

Some notes:

I did notice a side effect of running these tests. While they are executing, I am not able to able to change tabs or interact with Google Chrome.
Is there a way to see the browser that is being interacted with?

olivergondza commented 4 years ago

The behavior of google chrome is supper strange as the test suite is using containerized firefox.

Watching the execution is possible through vncviewer, though its port number is randomly generated on per test basis. For interactive debugging it would be easier to temporarily change the BROWSER value to real browser and on your host or inside ath-container (so your vncviewer do not have to reconnect for every test run).

scoheb commented 4 years ago

I can confirm BROWSER=firefox mvn test -Dtest=FedMsgMessagingPluginIntegrationTest#testPipelineInvalidProvider works just fine!

scoheb commented 4 years ago

once tests pass, I will merge!

scoheb commented 4 years ago

Released in Version 1.1.13

olivergondza commented 4 years ago

Great thanks!