Closed bgoncalv closed 4 years ago
FYI @Zlopez
@bgoncalv Yes, the Fedora Messaging msg
is the actual content of FedMsg message. So this is correct and intended behavior.
@Zlopez okay, thanks. If this behaviour is expected than this issue can be closed. We are going to need to change our code to parse the CI_MESSAGE differently and triggering on FedoraMessaging won't be a simple change of messaging provider.
In the Python implementation of Fedora messaging, there is a library that helps you with the parsing, but for the Java there isn't anything like this. But yes, these two are not compatible with each other.
@johnbieren fyi, note that some of the pipelines use CI_MESSAGE as parameter to some functions like https://github.com/openshift/contra-lib/blob/master/vars/kojiMessage.groovy so any pipeline that uses this will have to be fixed when changing the trigger from FedMSg to FedoraMessaging.
I noticed some difference between FedMsg implementation and RabbitMQ implementation. #168 should fix this.
When triggering using FedoraMessage the CI_MESSAGE contains information that I think shouldn't be part of CI_MESSAGE, at least it was not part of CI_MESSAGE when using FedMsg.
Example:
Fedora Message
FedMsg
Basically what is show in CI_MESSAGE from FedMsg is the content of CI_MESSAGE['msg'] from FedoraMessaging.