search

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 38 forks source link

Using CI trigger on parametrized builds strip all non text parameters #178

Closed scoheb closed 4 years ago

scoheb commented 4 years ago

When using CI trigger on Jenkins parametrized build strips all non text parameters like selectboxes. We use selectbox fields with options provided, so the first option is used as a default.

scoheb commented 4 years ago

Are you expecting to see the Select/Choice parameter to be set via the incoming message? Or are you just wanting to ensure that the default Select/Choice parameters are set to their default values?

cardil commented 4 years ago

Are you expecting to see the Select/Choice parameter to be set via the incoming message? Or are you just wanting to ensure that the default Select/Choice parameters are set to their default values?

I want to ensure that the defaults are used, for now. Currently, the values are "" and that's illegal. It should be the first value for Choice type.

cardil commented 4 years ago

It also relates to boolean params. The default value for a field should be used.

scoheb commented 4 years ago

So #179 will ensure defaults are chosen for choice params The current version already handles boolean params. Are you also seeing an issue with boolean?

scoheb commented 4 years ago

@cardil Snapshot binary available for testing here: https://ci.jenkins.io/job/Plugins/job/jms-messaging-plugin/job/PR-179/3/artifact/plugin/target/jms-messaging.hpi

cardil commented 4 years ago

I didn't see it for booleans. Just presumed it must be similar. Thanks for quick reaction!