search

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging
12 stars 37 forks source link

Make ProjectChangeListener to be Pipeline friendly #196

Closed ArturHarasimiuk closed 3 years ago

ArturHarasimiuk commented 4 years ago

Let's use ParameterizedJobMixIn.ParameterizedJob instead of AbstractProject when handling onUpdated event. This will allow for handling AbstractJob and WorkflowJob related updates.

Signed-off-by: Artur Harasimiuk artur.harasimiuk@intel.com

scoheb commented 4 years ago

I think you might need https://github.com/jenkinsci/jms-messaging-plugin/pull/197 to help the tests pass. Once CI passes for that MR, I will ping you and you can rebase.

scoheb commented 4 years ago

you can now rebase this PR

ArturHarasimiuk commented 4 years ago

rebased. however, PR build failed for some environment related problems. can we retry this somehow?

[2020-05-21T03:57:52.364Z] Could not connect to EC2 (aws) - High memory ubuntu 18.04 (i-076f3837a46864415) to send interrupt signal to process