Set message headers variable

jenkinsci / jms-messaging-plugin

https://plugins.jenkins.io/jms-messaging

12 stars 37 forks source link

Set message headers variable #229

Open brusdev opened 2 years ago

brusdev commented 2 years ago

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

ggallen commented 2 years ago

@brusdev , what problem are you trying to solve here?

brusdev commented 2 years ago

@ggallen a Jenkins job is able to get the message headers and content using the trigger[1] but not using the waitForCIMessage step. Feel free to close this PR if it doesn't make sense.

[1] https://github.com/jenkinsci/jms-messaging-plugin/blob/jms-messaging-1.1.24/plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/ActiveMqMessagingWorker.java#L270

ggallen commented 2 years ago

But @brusdev , the headers/properties are added in https://github.com/jenkinsci/jms-messaging-plugin/blob/jms-messaging-1.1.24/plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/ActiveMqMessagingWorker.java#L272-L279.

scoheb commented 2 years ago

I think what @brusdev is trying to get across is the fact that https://github.com/jenkinsci/jms-messaging-plugin/blob/50cd44351e6027074470a2ab7db189e5588796c1/plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/ActiveMqMessagingWorker.java#L525 only returns the message body and NOT the message headers.