Closed C0urante closed 7 months ago
CI is failing right now because an older version of the JUnit plugin is still used on this branch. Should pass when the dependency is updated.
Please, use the dependency management to fix the unit version coming from the BOM. Once the bom is released and updated here, that could be removed.
@alecharp thanks for the guidance on resolving the dependency misalignment. I gave it several tries using different variants of dependencyManagement
and even a version property, but all of those still got overridden (see the CI failures on recent commits). I've gotten things to work with an explicit dependency
element. I know it's a bit crass so please let me know if there's a cleaner way to go about this.
Thanks!
This ports upstream changes from the JUnit plugin that replaced the
keepLongStdio
property withstdioRetention
in https://github.com/jenkinsci/junit-plugin/pull/601. Without this change, this plugin is incompatible with newer releases of the JUnit plugin.Testing done
I tweaked the POM to use the latest release of the JUnit plugin, then ran existing unit tests. As reported elsewhere, the
RealtimeJUnitStepTest::ui
case failed. After these changes, that test succeeded, and I was able to verify that the UI contains the correct values for the property in the dropdown form. For good measure, I also added another round trip config test with a new value for thestdioRetention
property.