search

jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator
https://jenkinsci.github.io/kubernetes-operator
Other
591 stars 231 forks source link

jnlpUrl deprecated #1024

Closed necipakca closed 1 day ago

necipakca commented 1 week ago

We are getting deprecation;

WARNING hudson.slaves.SlaveComputer#doJenkinsAgentJnlp: Agent "seed-job-agent" is connecting with the "-jnlpUrl" argument, which is deprecated. Use "-url" and "-name" instead, potentially also passing in "-webSocket", "-tunnel", and/or work directory options as needed.

Jenkins Operator version: quay.io/jenkins-kubernetes-operator/operator:v0.8.0

brokenpip3 commented 1 week ago

it's already fixed here: https://github.com/jenkinsci/kubernetes-operator/commit/061995a65ca4a6edb8e7a50fa5ea9f9446c393e1

I'm planning a bugfix release soon, in the mean time you can use: quay.io/jenkins-kubernetes-operator/operator:e0f52b5

necipakca commented 1 week ago

Thanks for quick feedback. I updated operator with e0f52b5 but still I am getting the warning. Do I need to add extra ENV to Jenkins CRD ?

brokenpip3 commented 4 days ago

yep you are right, not sure why is still complaining, the seed job agent command is a simple:

/opt/java/openjdk/bin/java -jar /usr/share/jenkins/agent.jar \
-secret <secret> \
-name seed-job-agent \
-url <svc-name> \
-workDir /home/jenkins/agent \
-webSocket

will take a look

brokenpip3 commented 4 days ago

Ok I found the issue looking on the upstream code. We need to change this method here, will do it in the following days

brokenpip3 commented 1 day ago

@necipakca it should be fixed now, can you test quay.io/jenkins-kubernetes-operator/operator:51c3bb8 and let me know? feel free to comment if the issue will persist, I will re-open the issue