Open moh-abk opened 4 years ago
any update on this @tomaszsek
Any timeline on this? We're also looking to inject a sidecar proxy in our Jenkins pod.
Team, any update on this? @tomaszsek
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue is still affecting you, just comment with any updates and we'll keep it open. Thank you for your contributions.
@Sig00rd Is there any progress on this? We need to add istio sidecars to make Jenkins usable for our production.
@Sig00rd Is there any progress on this? We need to add istio sidecars to make Jenkins usable for our production.
@Sig00rd is not part of the maintainers anymore :(
I can see from the code that the deployment instead of pod is supported (even if does not seems officially released as option). You can try it via an annotation on the jenkins crd, check this code: https://github.com/jenkinsci/kubernetes-operator/blob/44a7d2460a97a74ae1dd21e286a342bec805c794/pkg/configuration/base/reconciler.go#L129
Let me know
@brokenpip3 Is this properly tested? I hava added the annotation to jenkins master CR, but still the operator creates a pod instead of deployment.
Was possible in the past: https://github.com/jenkinsci/kubernetes-operator/issues/361#issuecomment-1278270760
I need to understand why is not working atm.
To fix this I would like to try a different path: in the reconciliation loop skip a container in the pod if the name is istio-proxy
or linkerd-proxy
etc.
Which version of istio are you using and what is the name of the injected istio container?
@brokenpip3 Sorry for the late response. The injected container's name is istio-proxy
and we are using version:1.14.6
Expected Behavior
by adding the below we shouldn't see any breaking of the Jenkins operator/jenkins
Jenkins and operator were running perfectly prior to the change.
Actual Behavior
Jenkins operator isn't able to start jenkins cr, logs below;
Steps to Reproduce the Problem
operator
injenkins-operator
namespacejenkins
injenkins
namespacejenkins
namespace to allow istio automatic sidecar injectionAdditional Info
Kubernetes version:
Output of
kubectl version
: