jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator
https://jenkinsci.github.io/kubernetes-operator
Other
599 stars 236 forks source link

vanilla manifest still points to outdated image on docker.com #827

Closed pniederlag closed 1 year ago

pniederlag commented 1 year ago

Describe the bug vanilla manifests ( https://github.com/jenkinsci/kubernetes-operator/blob/master/deploy/all-in-one-v1alpha2.yaml) still point to docker.com for the images while the chart (https://github.com/jenkinsci/kubernetes-operator/blob/master/chart/jenkins-operator/values.yaml) has been migrated to images pulled from quay.io

To Reproduce check above links and see different repositiories being used for the operator image

Additional information

Kubernetes version: Jenkins Operator version: github master branch

brokenpip3 commented 1 year ago

do you think we need to continue to support the all in one files? Will be complicated to maintain due to the helm chart as official method

dropte commented 1 year ago

do you think we need to continue to support the all in one files? Will be complicated to maintain due to the helm chart as official method

If it's not going to be supported, it needs to go away, IMO. We still deploy via it with a lot of patching via kustomize/argocd. It'd be very nice to have a non-helm deployment method though.

pniederlag commented 1 year ago

I second @dropte here. Being outdated is more anyoing than just dropping them.

While it might be nice for some use-cases to have plain kubernetes manifests I think it is feasible to lower the burden on maintainers by just providing helm-chart as official installation method.

It is quite simple to generate manifests from helm-charts by helm template for those in needs of applying vanilla manifests... At least we have now migrated our setup to helm chart. :->

brokenpip3 commented 1 year ago

@dropte you got me at kustomize/gitops :D

I will add a CI step that will "helm template" and commit those files here

(btw do you know that flux has a native helm support? I install the jenkins operator, among all the others things, with that)

dropte commented 1 year ago

Yes, we use flux elsewhere, but manage our whole stack with ArgoCD and kustomize. Argo can use helm as well, it's just sort of annoying jumping back and forth from kustomize to helm.

We use two different Argo apps - one for the operator and one for the configuration and it's nice to do something like this:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - https://raw.githubusercontent.com/jenkinsci/kubernetes-operator/master/config/crd/bases/jenkins.io_jenkins.yaml
  - https://raw.githubusercontent.com/jenkinsci/kubernetes-operator/master/deploy/all-in-one-v1alpha2.yaml
  - ingress.yaml

and then point argo at that.

brokenpip3 commented 1 year ago

it's an easy CI implementation, will do it shortly

brokenpip3 commented 1 year ago

I will work on this after this PR: https://github.com/jenkinsci/kubernetes-operator/pull/833

brokenpip3 commented 1 year ago

hei @pniederlag @dropte I create a workflow that will update automatically the operator image, deploy and rbac, can you check if this PR #864 will satisfy your flow?

I may need to make it better and clean something there, will do it this week and release a new operator version

brokenpip3 commented 1 year ago

Should be fixed in this release: https://github.com/jenkinsci/kubernetes-operator/releases/tag/v0.8.0-beta2, let me know if you still have problem.