search

jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator
https://jenkinsci.github.io/kubernetes-operator
Other
596 stars 233 forks source link

Ingress for Jenkins instance #896

Open diptripa opened 11 months ago

diptripa commented 11 months ago

Describe the solution you'd like Option Ingress resource for jenkins instance created using the operator

Describe alternatives you've considered Creating ingress manually

brokenpip3 commented 11 months ago

Yep this is a fair request, I marked it as "Good first issue", PRs are welcome :)

AniketNS commented 8 months ago

Hey @brokenpip3, I'd like to work on this issue. Will you please assign this to me?

brokenpip3 commented 8 months ago

Done :)

AniketNS commented 8 months ago

May I trouble you, @brokenpip3, if I need any help?

brokenpip3 commented 8 months ago

show me the code and I will help for sure, create a draft PR :)

AniketNS commented 8 months ago

Hello @brokenpip3, Will you please elaborate on the issue? and what should I supposed to do.

brokenpip3 commented 8 months ago

Adding an ingress resource and the ingress values in the operator helm chart

AniketNS commented 7 months ago

Hey @brokenpip3, I've opened the PR related to this issue. But the problem is I was also solving issue #937 and I've already opened the PR for that yesterday. But still when I'm trying to push the current code for the current issue with a new branch(a different branch that was used for the #937 issue) still that file is being added to PR.

Will you please guide me on how can I solve this problem?

brokenpip3 commented 6 months ago

But still when I'm trying to push the current code for the current issue with a new branch(a different branch that was used for the https://github.com/jenkinsci/kubernetes-operator/issues/937 issue) still that file is being added to PR.

Will you please guide me on how can I solve this problem?

this is a git flow issue (or better it's the normal flow), you started the ingress branch from the history of the ldap branch, instead you need to start from the lastest master commit. So you are in the AniketNS:ingress-jenkins branch right? do the following

go here: https://github.com/AniketNS/kubernetes-operator/tree/master and force the sync

git reset HEAD~2
git stash
git fetch origin
git checkout master
git branch -D ingress-jenkins
git rebase <or merge> origin/master
git checkout -b ingress-jenkins
git stash pop
git commit -m "something" chart
git push origin ingress-jenkins --force-with-lease

but also you need to add more in the PR, the ingress needs to be optional, not enabled by default and you need to add the options in values.yaml