jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator
https://jenkinsci.github.io/kubernetes-operator
Other
596 stars 233 forks source link

Combine dark and regular logo in README.md #915

Closed pyatizbyantsevia closed 9 months ago

pyatizbyantsevia commented 10 months ago

Changes

Since the paths between the repositories to assets/ are different, the working version can be viewed on the master branch of my fork.

It might be worth creating a logo in .svg format so as not to have 2 files and encapsulate all the logic inside the svg, as in design-library-plugin

To check the functionality, you can open two tabs: master branch in my fork, appearance settings. By switching the style on the appearance tab and then refreshing the fork page, you can see the functionality

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior
pyatizbyantsevia commented 10 months ago

If this PR is accepted, then before the merge I would be very grateful if there was a label for Hacktoberfest (hactoberfest-accepted)

pyatizbyantsevia commented 10 months ago

@brokenpip3, could you take a look?

brokenpip3 commented 9 months ago

Yes, sorry will take a look during this week

brokenpip3 commented 9 months ago

thanks for your contribution

pyatizbyantsevia commented 9 months ago

Thank you! Sorry, I made a mistake in the label name, it should be "hacktoberfest-accepted", missed the 'k'. Thanks again!

brokenpip3 commented 9 months ago

done