jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator
https://jenkinsci.github.io/kubernetes-operator
Other
596 stars 233 forks source link

Provides an Override to the WATCH_NAMESPACE env variable. #923

Closed valenca closed 6 months ago

valenca commented 9 months ago

In case the Jenkins instance is disabled, this commit allows us to pick a different namespace for the deployment by configuring the operator object instead of the jenkins object.

Changes

Adds a new operator.watchNamespace value that should be used in case jenkins.enabled is set to false. Updates and cleans up the documentation to reflect this change.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes: New operator.watchNamespace values.yaml configuration.
- Bug fixes #922 
- Any changes in behavior: None
brokenpip3 commented 8 months ago

The test are failing for another reason, I will fix it so you can merge master in this branch e we can merge the PR.

brokenpip3 commented 8 months ago

Can you merge/rebase master in this PR?

brokenpip3 commented 6 months ago

Thanks for your contribution