[WIP] Road to version 9.0: update to go 1.21 and operator-sdk 1.35

jenkinsci / kubernetes-operator

Kubernetes native Jenkins Operator

https://jenkinsci.github.io/kubernetes-operator

Other

598 stars 233 forks source link

[WIP] Road to version 9.0: update to go 1.21 and operator-sdk 1.35 #954

Open brokenpip3 opened 9 months ago

brokenpip3 commented 2 months ago

@ansh-devs hi :wave:

thanks for stepping in :tada: since I don't have time for this in the following weeks. I fixed all the conflict, merged master and starting fixing the golang-ci linter warnings and some of code problems after the golang and library update.

Feel free to open another branch and work on top of this one :)

My suggestion is to start from fixing the build and then the ci linter warnings. Let me know if you want to work on this in the following days, in case we can also have a chat in gitter if you have any doubts :)

ansh-devs commented 2 months ago

@ansh-devs hi 👋

thanks for stepping in 🎉 since I don't have time for this in the following weeks. I fixed all the conflict, merged master and starting fixing the golang-ci linter warnings and some of code problems after the golang and library update.

Feel free to open another branch and work on top of this one :)

My suggestion is to start from fixing the build and then the ci linter warnings. Let me know if you want to work on this in the following days, in case we can also have a chat in gitter if you have any doubts :)

@brokenpip3 Ok, I will continue with the refactoring 🛠️ taking this as the base can you assign me as well in this !

ansh-devs commented 2 months ago

Hi @brokenpip3, I have fixed the breaking changes also updated to go version to 1.22.

Changes -

[x] Updated Go version to - v1.22
[x] Updated Mocks for pkg/controller/jenkins/client/jenkins.go to support new changes
[x] Refactored code to adapt Context API
[x] Refactored existing code to satisfy golangci linter
[x] Above changes has fixed all the build errors

Next/Upcoming -

[x] Fixing the E2E and HELM test

ansh-devs commented 2 months ago

@brokenpip3 how can I join the Slack workspace

brokenpip3 commented 2 months ago

Hi @brokenpip3, I have fixed the breaking changes also updated to go version to 1.22.

Changes -

Great great progress! :clap: Thanks for taking care of this part :)

I saw that you are working on your fork, could you please open a PR against this branch? You can just open a normal PR but instead of targeting master you can target this branch: version-9.0. I'm asking because for me will be much easier to help you in case of questions and to start reviewing the code :)

@brokenpip3 how can I join the Slack workspace

There is no slack workplace, you can join the matrix room from any client you want, gitter for instance. But I saw you already joned it so we can continue the discussion there if you like :) Or you can write me an email here <mygithubusername>[at]gmail[dot].com

ansh-devs commented 2 months ago

@brokenpip3 Refer this - #1037