search

jenkinsci / last-changes-plugin

https://plugins.jenkins.io/last-changes
https://plugins.jenkins.io/last-changes/
31 stars 30 forks source link

Runs diff on the actual node instead of copying VCS dir to master note #73

Closed david-mntl closed 4 years ago

david-mntl commented 4 years ago

I implemented the fix for the issue #66. Now if the build is done on the slave then the source control folder (.git or .svn) will not be copied to master node and the diff will be done on the slave. The case, when the build is executed on the master node, is also handled properly.

david-mntl commented 4 years ago

I will try to analyze the issue reported by jenkins-ci above and update the PR.

david-mntl commented 4 years ago

It looks like the error presents in all previous CI executions, so it does not look like it was introduced by me. I ran the tests locally in windows environment and all of them succeed.

rmpestano commented 4 years ago

Hi @david-mntl, that's awesome! I'll review this PR tomorrow.

Thank you very much!