jenkinsci / lib-file-leak-detector

Java agent that detects file handle leak
http://file-leak-detector.kohsuke.org/
MIT License
241 stars 112 forks source link

why http need readline first? #185

Open JinHeap opened 3 months ago

JinHeap commented 3 months ago

What feature do you want to see added?

I did not use a browser; instead, I used telnet (e.g., telnet 127.0.0.1 9999) to retrieve the status. I found that I needed to press Enter to display some information. And apart from HTTP, I didn't find any other way to retrieve the status. Actually, using telnet is more convenient than using a browser. I hope to remove readline first. I tested after removing readline and Chrome browser was working normally.

Upstream changes

https://github.com/jenkinsci/lib-file-leak-detector/commit/e0bede6fd8f063345f705e5692ae5820c3c4d5b4

Are you interested in contributing this feature?

No response

centic9 commented 3 months ago

I'd say file-leak-detector simply adheres to the HTTP spec here and thus it wants to read the HTTP GET request properly.

Why don't you use curl for such a thing here instead of telnet?

JinHeap commented 3 months ago

curl is good suggestion. But I use wireshark to check packet from chrome find is so many line in request, does http read first line is must? image