[JENKINS-53394] A invalid property set on the configuration from the UI of file-leak-detector kills the Jenkins instance - Githubissues

jenkinsci / lib-file-leak-detector

Java agent that detects file handle leak

http://file-leak-detector.kohsuke.org/

MIT License

241 stars 112 forks source link

[JENKINS-53394] A invalid property set on the configuration from the UI of file-leak-detector kills the Jenkins instance #41

Closed MRamonLeon closed 5 years ago

MRamonLeon commented 5 years ago

See [JENKINS-53394] A invalid property set on the configuration from the UI of file-leak-detector kills the Jenkins instance

Remove the System.exit to avoid killing the Java Virtual Machine.

Discussed several approaches in:

https://github.com/kohsuke/file-leak-detector/pull/39 Remove System.exit
https://github.com/kohsuke/file-leak-detector/pull/40 Remove System.exit plus optional argument

This PR is the option chosen, removed System.exit and added an exception to be able to know what went on in the agent.

jeffret-b commented 5 years ago

@kohsuke We think that only you have access to maintain this repo. We'd like to ask if you'd be willing to share that responsibility. Or at a minimum to process this PR. I'm a maintainer on the file-leak-detector plugin so I'd gladly agree to be a co-maintainer on this one.