search

jenkinsci / lib-file-leak-detector

Java agent that detects file handle leak
http://file-leak-detector.kohsuke.org/
MIT License
241 stars 112 forks source link

[JENKINS-53394] Check null options #43

Closed MRamonLeon closed 5 years ago

MRamonLeon commented 5 years ago

Without this check, the activation of the agent fails with:

Unknown option: null

Because the arguments are: noexit,null

MRamonLeon commented 5 years ago

Sorry @batmat, but it's hard to test because we have to use a ProcessBuilder to launch the process to attach to, find out a way to know the name of the fat-jar without introducing too many dependencies, etc. Is a screenshot enough? :-)

options comes as null:

screenshot from 2018-10-30 17-40-20

kohsuke commented 5 years ago

Well this is embarrassing! I thought I experimented with this case but I guess the difference of having '=' or not makes the difference between null and empty string!