jenkinsci / lib-file-leak-detector

Java agent that detects file handle leak
http://file-leak-detector.kohsuke.org/
MIT License
241 stars 112 forks source link

Java11 #48

Closed akwiatek closed 2 years ago

akwiatek commented 4 years ago

@kohsuke

This PR tries to address issue #46 and adds support for Java11. This PR essentially upgrades asm from version 6.0 to version 7.2 .

I have checked the changes against both Java8 and Java11 and was able to successfully:

I have gathered less invasive changes in the 1st commit ( e9ac84a ) and moved it into PR #47 hoping they could be merged faster.

Due to lack of org.kohsuke.asm7 package I had to switch to the upstream version ( org.ow2.asm ) . I'm not sure why asm6 has been re-packaged in the first place TBH, but the detector appears to work just fine without that re-packaging.

Of course, once there is org.kohsuke.asm7 available switching to org.ow2.asm won't be necessary.

jumarko commented 4 years ago

Works nicely on JDK 11, thanks a lot for this!