jenkinsci / lib-file-leak-detector

Java agent that detects file handle leak
http://file-leak-detector.kohsuke.org/
MIT License
241 stars 112 forks source link

Fine-grained SpotBugs exclusions #78

Closed basil closed 2 years ago

basil commented 2 years ago

Problem

Currently, we exclude any medium-threshold SpotBugs violations. This means that existing violations don't trip up the build, but it also means we won't notice if new medium-threshold violations get introduced.

Solution

Add an exclude filter file with fine-grained suppressions of specific medium-threshold violations for the classes that currently violate them. This way, the build remains green, but if a new medium-threshold violation gets introduced, we would notice that right away.