jenkinsci / lockable-resources-plugin

Lock resources against concurrent use
https://plugins.jenkins.io/lockable-resources
MIT License
87 stars 183 forks source link

ConcurrentModificationException-at-LockedResourcesBuildAction #626

Closed mPokornyETM closed 7 months ago

mPokornyETM commented 7 months ago

Using many parallel locks at the same time in the same job (like parallel stages does) leads to java.util.ConcurrentModificationException in the org.jenkins.plugins.lockableresources.actions.LockedResourcesBuildAction#lockedResources

Testing done

Writing tests for this scenario is too hard, because no body can really simulate it. It happens sometimes on our environment.

Proposed upgrade guidelines

N/A

Localizations

N/A

Submitter checklist

jamoralp commented 7 months ago

Is it known when this issue started? We're facing it once in a while now (hoping this fix is merged soon!) but we've been using in our company Jenkins lockable resources for a couple of years and never ran into this before. Would be great to know which version introduced the issue to at least downgrade to a previous one until this is merged and released

mPokornyETM commented 7 months ago

Is it known when this issue started? We're facing it once in a while now (hoping this fix is merged soon!) but we've been using in our company Jenkins lockable resources for a couple of years and never ran into this before. Would be great to know which version introduced the issue to at least downgrade to a previous one until this is merged and released

I think you mean #623 This failure might happens, when parallel stages in the same job are running at the same time. Not on jenkins start up. Anyway u will merge it assap. One fix more is still better, then no fix