jenkinsci / lucene-search-plugin

Jenkins plugin for searching job data via Lucene or Solr
https://plugins.jenkins.io/lucene-search
MIT License
5 stars 13 forks source link

Support Command Palette #69

Open janfaracik opened 3 months ago

janfaracik commented 3 months ago

As part of https://github.com/jenkinsci/jenkins/pull/7569, Jenkins replaces the existing search input in the header for a Command Palette.

With this change the existing implementation of this plugin no longer works. https://github.com/jenkinsci/jenkins/pull/7569 however introduces support for plugins adding their own buttons to the navigation bar. This has briefly been discussed as a workaround so that this plugin can still continue to work.

image

This draft MR introduces a new button to the navigation bar, currently called 'Lucene' which allows users to navigate to the existing Lucene search page. On that page a new search input has been introduced, allowing users to search with Lucene as they previously could.

image

Testing done

See https://github.com/jenkinsci/lucene-search-plugin/pull/69#issuecomment-2242521900

Submitter checklist

janfaracik commented 3 months ago

Searching for nothing via the new search bar and old search bar

image

Searching for 'built' via the new search bar and old search bar

image

Searching for 'feat' inside of a job via the new search bar and old search bar

image

The above scenarios work the same - there might be scenarios I'm unaware of so do let me know if I've missed anything.

janfaracik commented 3 months ago

Any thoughts on this @daniel-beck?