jenkinsci / mac-plugin

Plugin to configure Macs as Jenkins agents
https://plugins.jenkins.io/mac/
MIT License
12 stars 12 forks source link

Correct the missing CSRF for two check methods #12

Closed Wadeck closed 4 years ago

Wadeck commented 4 years ago

Correct: Screenshot_2020-03-04_143711_001

mat1e commented 4 years ago

@Wadeck, I never got this error, but your correction works for me.

Wadeck commented 4 years ago

@mat1e I hope you have not a disabled CSRF protection on your instance ;)

mat1e commented 4 years ago

@mat1e I hope you have not a disabled CSRF protection on your instance ;)

@Wadeck I checked and It was disabled on my local instance. I enabled it. Thanks !

mat1e commented 4 years ago

@Wadeck, have you an idea why I have a warning in jenkins plugin managment for mac-plugin 1.2.1 ?

image

On the plugin page, I see it affect only version 1.1.0 and earlier :

image

Wadeck commented 4 years ago

Hello @mat1e, it seems that there was a problem during the advisory publication due to the new version published before/during/after the advisory that was taken into account for the warning regex. We will manage to correct this.

"Culprits":

I will ping you in the PR when ready.

Wadeck commented 4 years ago

=> https://github.com/jenkins-infra/update-center2/pull/391 to remove the 1.2.1 version from the warning.

mat1e commented 4 years ago

Thank you @Wadeck for your help !