Internalise fonts - Githubissues

jenkinsci / material-theme-plugin

A Material theme plugin for Jenkins.

https://plugins.jenkins.io/material-theme/

MIT License

16 stars 16 forks source link

Closed timbrown5 closed 2 years ago

timbrown5 commented 2 years ago

Fixes: #9

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira

timbrown5 commented 2 years ago

From my (fairly light) local testing.

If I remove the 'src/main/webapp/resources/fonts' directory the browser resorts to Time New Roman: To me this shows that the fonts are picked up from that location

For reference here is the same page with that directory present. Screenshot 2022-09-09 at 15 46 32

timbrown5 commented 2 years ago

@timja Sorry for dumping all the reviews on you (you were the suggested reviewer).

Is there anyone else who could/should be assigned?

timja commented 2 years ago

@timja Sorry for dumping all the reviews on you (you were the suggested reviewer).

Is there anyone else who could/should be assigned?

you're the only maintainer so either you or if you have questions you could ping the @jenkinsci/sig-ux team