jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins
https://plugins.jenkins.io/nomad/
MIT License
56 stars 41 forks source link

relax enforcer rule for kotlin-stdlib #144

Closed j3t closed 2 years ago

j3t commented 2 years ago

relax enforcer rule for kotlin-stdlib

see https://github.com/jenkinsci/nomad-plugin/pull/143 and https://github.com/square/okhttp/issues/7328 for more details

j3t commented 2 years ago

One test is failing at the moment on Linux org.jenkinsci.plugins.nomad.NomadApiTLSTest.testClientIsNotTrustworthyWithDefaultCA. On Windows, the test is running fine and on my local machine (MacOS) it is fine as well. Also, the Jenkins Linux build is very slow at the moment (Windows: 2min 48s, Linux: 6min 51s). Could be related, I will try it later again.

multani commented 2 years ago

I also couldn't reproduce the test failure on my machine, I suspect it may come from a different underlying libssl library on the Jenkins test worker perhaps?

j3t commented 2 years ago

Yes, I have the same feeling. I relaxed the assertions. The exact error message is not that important I guess.

multani commented 2 years ago

@j3t Do you want to make a new release with this fix?

j3t commented 2 years ago

@j3t Do you want to make a new release with this fix?

No, for me it's fine without a new release.